feat: MCP Bridge Workbench, just command cleanup, testing, etc. (#24)
* fix: lots of fixes and name refactoring * feat: Add workbench preferences * fix: MCP bridge status widget and just command fixes * fix(tests): Use the correct mesa-glx package * fix(ci): Add fontconfig to GUI test dependencies FreeCAD GUI was failing to start with: "Fontconfig error: Cannot load default config file: No such file" Added fontconfig and fonts-dejavu-core packages to the GUI test job dependencies to resolve the font configuration issue. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(addon): Extract path utilities into shared module Create path_utils.py module that consolidates duplicated path-finding logic from commands.py and InitGui.py: - get_addon_path(): Find addon directory with caching and fallbacks - get_icon_path(): Get full path to an icon file - get_icons_dir(): Get path to icons directory - get_workbench_icon(): Get path to workbench main icon This removes ~100 lines of duplicated code while preserving the same behavior including _addon_path_cache and all fallback methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(addon): Prevent stale plugin state on startup failure The StartMCPBridgeCommand.Activated method could leave _mcp_plugin in a partially initialized state if FreecadMCPPlugin.start() failed after the plugin was instantiated. Changes: - Create plugin in a local variable first - Only assign to _mcp_plugin after start() succeeds - Explicitly clear _mcp_plugin and _running_config in exception handlers to ensure clean state for subsequent retry attempts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Lot of broad improvements * fix(ci): Use blocking headless_server.py for GUI tests The GUI test was using startup_bridge.py which is non-blocking (designed for interactive use). For CI, even in GUI mode, we need the blocking headless_server.py that calls run_forever() to keep FreeCAD running. GUI features are still available since we use the 'freecad' executable instead of 'freecadcmd'. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(addon): Rename headless_server.py to blocking_bridge.py The old name was misleading because: - It works with both GUI (freecad) and headless (freecadcmd) modes - The key characteristic is that it BLOCKS with run_forever() New naming convention clarifies the difference: - blocking_bridge.py: Starts bridge and blocks (for CI, servers) - startup_bridge.py: Starts bridge and returns (for interactive GUI) Updated all references across: - GitHub workflow (macro-test.yaml) - Just commands (freecad.just) - Unit tests (test_addon_structure.py) - Documentation (5 files) - CLAUDE.md Also improved the script to detect GUI mode dynamically using FreeCAD.GuiUp and display the appropriate status message. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(just): Remove erroneous rm of startup_bridge.py on error The startup script is now a permanent source file in the repository, not a generated temporary file. The rm -f would have deleted source code if FreeCAD wasn't found. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: General improvements * fix: Lots of general fixes and only stable to PyPi * fix: small cleanup * fix: Small fixes and hopefully fixes the GUI tests * fix: Add proper library paths for FreeCAD GUI in CI - Create wrapper scripts instead of symlinks for AppImage binaries - Set LD_LIBRARY_PATH, QT_PLUGIN_PATH for GUI mode - Add diagnostic output to identify startup failures * fix: Use apprun for GUI tests in CI * fix: Improving Xvfb tests * fix: GUI tests worlk * chore: remove invalid --no-splash comments * fix: ARM64 architecture support and other fixes * fix: cleanup * test: just commands test suite * test: improve just command tests * fix: more general improvements * fix: more cleanup * fix: more updates * fix: small tweaks --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Sean P. Kane
co-authored by
Claude Opus 4.5
Claude Opus 4.5
parent
bcc3048876
commit
8c338f6da7
@@ -0,0 +1,156 @@
|
||||
"""Tests for just command listing functionality.
|
||||
|
||||
These tests verify that all listing commands work correctly and
|
||||
that all expected modules are accessible.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from typing import TYPE_CHECKING, ClassVar
|
||||
|
||||
import pytest
|
||||
|
||||
if TYPE_CHECKING:
|
||||
from tests.just_commands.conftest import JustRunner
|
||||
|
||||
|
||||
class TestListCommands:
|
||||
"""Test just command listing functionality."""
|
||||
|
||||
@pytest.mark.just_syntax
|
||||
def test_default_lists_commands(self, just: JustRunner) -> None:
|
||||
"""Default command should list available commands."""
|
||||
result = just.run("default", timeout=10)
|
||||
assert result.success, f"Failed: {result.stderr}"
|
||||
# Should show at least some commands
|
||||
assert "setup" in result.stdout or "all" in result.stdout
|
||||
|
||||
@pytest.mark.just_syntax
|
||||
def test_list_all_shows_all_modules(self, just: JustRunner) -> None:
|
||||
"""list-all should show commands from all modules."""
|
||||
result = just.run("list-all", timeout=10)
|
||||
assert result.success, f"Failed: {result.stderr}"
|
||||
# Should include module headers (e.g., "quality:" or "testing:")
|
||||
assert "quality:" in result.stdout or "testing:" in result.stdout
|
||||
|
||||
@pytest.mark.just_syntax
|
||||
@pytest.mark.parametrize(
|
||||
"module",
|
||||
[
|
||||
"coderabbit",
|
||||
"dev",
|
||||
"docker",
|
||||
"documentation",
|
||||
"freecad",
|
||||
"install",
|
||||
"mcp",
|
||||
"quality",
|
||||
"release",
|
||||
"testing",
|
||||
],
|
||||
)
|
||||
def test_list_module_commands(self, just: JustRunner, module: str) -> None:
|
||||
"""Each module listing command should work."""
|
||||
result = just.run(f"list-{module}", timeout=10)
|
||||
assert result.success, f"list-{module} failed: {result.stderr}"
|
||||
# Output should not be empty
|
||||
assert result.stdout.strip(), f"list-{module} returned empty output"
|
||||
|
||||
|
||||
class TestModulesExist:
|
||||
"""Test that all expected modules and commands exist."""
|
||||
|
||||
# Map of modules to their expected commands (subset for validation)
|
||||
EXPECTED_COMMANDS: ClassVar[dict[str, list[str]]] = {
|
||||
"quality": ["check", "format", "lint", "typecheck", "security"],
|
||||
"testing": ["unit", "cov", "fast", "integration"],
|
||||
"dev": ["install-deps", "install-pre-commit", "clean"],
|
||||
"docker": ["build", "run", "clean"],
|
||||
"documentation": ["build", "serve", "open"],
|
||||
"install": ["mcp-server", "mcp-bridge-workbench", "status"],
|
||||
"mcp": ["run", "check"],
|
||||
"freecad": ["run-gui", "run-headless"],
|
||||
"release": ["status", "list-tags", "latest-versions"],
|
||||
"coderabbit": ["install", "review"],
|
||||
}
|
||||
|
||||
@pytest.mark.just_syntax
|
||||
@pytest.mark.parametrize("module,commands", EXPECTED_COMMANDS.items())
|
||||
def test_module_has_expected_commands(
|
||||
self, just: JustRunner, module: str, commands: list[str]
|
||||
) -> None:
|
||||
"""Each module should have its expected commands."""
|
||||
# Use list_commands to get parsed command names
|
||||
available_commands = just.list_commands(module)
|
||||
assert available_commands, f"No commands found in {module} module"
|
||||
|
||||
for cmd in commands:
|
||||
assert cmd in available_commands, (
|
||||
f"Command '{cmd}' not found in {module} module. "
|
||||
f"Available: {available_commands}"
|
||||
)
|
||||
|
||||
|
||||
class TestSyntaxValidation:
|
||||
"""Test that all commands have valid syntax (dry-run)."""
|
||||
|
||||
# Commands that can be safely dry-run tested
|
||||
SAFE_DRY_RUN_COMMANDS: ClassVar[list[str]] = [
|
||||
# Main justfile
|
||||
"setup",
|
||||
"all",
|
||||
# Quality commands
|
||||
"quality::check",
|
||||
"quality::format",
|
||||
"quality::lint",
|
||||
"quality::typecheck",
|
||||
"quality::security",
|
||||
"quality::scan",
|
||||
"quality::markdown-lint",
|
||||
# Testing commands
|
||||
"testing::unit",
|
||||
"testing::cov",
|
||||
"testing::fast",
|
||||
"testing::verbose",
|
||||
# Dev commands
|
||||
"dev::install-deps",
|
||||
"dev::install-pre-commit",
|
||||
"dev::clean",
|
||||
"dev::validate",
|
||||
# Documentation commands
|
||||
"documentation::build",
|
||||
"documentation::build-strict",
|
||||
"documentation::serve",
|
||||
"documentation::open",
|
||||
# Docker commands (dry-run safe)
|
||||
"docker::build",
|
||||
"docker::run",
|
||||
"docker::shell",
|
||||
"docker::inspect",
|
||||
"docker::clean",
|
||||
# Install commands
|
||||
"install::mcp-server",
|
||||
"install::mcp-bridge-workbench",
|
||||
"install::macro-cut",
|
||||
"install::macro-export",
|
||||
"install::status",
|
||||
# MCP commands
|
||||
"mcp::check",
|
||||
"mcp::run",
|
||||
# FreeCAD commands
|
||||
"freecad::run-gui",
|
||||
"freecad::run-headless",
|
||||
# Release commands (read-only ones)
|
||||
"release::status",
|
||||
"release::list-tags",
|
||||
"release::latest-versions",
|
||||
]
|
||||
|
||||
@pytest.mark.just_syntax
|
||||
@pytest.mark.parametrize("command", SAFE_DRY_RUN_COMMANDS)
|
||||
def test_command_syntax_valid(self, just: JustRunner, command: str) -> None:
|
||||
"""Command should have valid syntax (just --dry-run succeeds)."""
|
||||
result = just.dry_run(command)
|
||||
assert result.success, (
|
||||
f"Syntax error in '{command}': {result.stderr}\n{result.stdout}"
|
||||
)
|
||||
Reference in New Issue
Block a user