* fix: lots of fixes and name refactoring * feat: Add workbench preferences * fix: MCP bridge status widget and just command fixes * fix(tests): Use the correct mesa-glx package * fix(ci): Add fontconfig to GUI test dependencies FreeCAD GUI was failing to start with: "Fontconfig error: Cannot load default config file: No such file" Added fontconfig and fonts-dejavu-core packages to the GUI test job dependencies to resolve the font configuration issue. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(addon): Extract path utilities into shared module Create path_utils.py module that consolidates duplicated path-finding logic from commands.py and InitGui.py: - get_addon_path(): Find addon directory with caching and fallbacks - get_icon_path(): Get full path to an icon file - get_icons_dir(): Get path to icons directory - get_workbench_icon(): Get path to workbench main icon This removes ~100 lines of duplicated code while preserving the same behavior including _addon_path_cache and all fallback methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(addon): Prevent stale plugin state on startup failure The StartMCPBridgeCommand.Activated method could leave _mcp_plugin in a partially initialized state if FreecadMCPPlugin.start() failed after the plugin was instantiated. Changes: - Create plugin in a local variable first - Only assign to _mcp_plugin after start() succeeds - Explicitly clear _mcp_plugin and _running_config in exception handlers to ensure clean state for subsequent retry attempts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Lot of broad improvements * fix(ci): Use blocking headless_server.py for GUI tests The GUI test was using startup_bridge.py which is non-blocking (designed for interactive use). For CI, even in GUI mode, we need the blocking headless_server.py that calls run_forever() to keep FreeCAD running. GUI features are still available since we use the 'freecad' executable instead of 'freecadcmd'. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(addon): Rename headless_server.py to blocking_bridge.py The old name was misleading because: - It works with both GUI (freecad) and headless (freecadcmd) modes - The key characteristic is that it BLOCKS with run_forever() New naming convention clarifies the difference: - blocking_bridge.py: Starts bridge and blocks (for CI, servers) - startup_bridge.py: Starts bridge and returns (for interactive GUI) Updated all references across: - GitHub workflow (macro-test.yaml) - Just commands (freecad.just) - Unit tests (test_addon_structure.py) - Documentation (5 files) - CLAUDE.md Also improved the script to detect GUI mode dynamically using FreeCAD.GuiUp and display the appropriate status message. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(just): Remove erroneous rm of startup_bridge.py on error The startup script is now a permanent source file in the repository, not a generated temporary file. The rm -f would have deleted source code if FreeCAD wasn't found. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: General improvements * fix: Lots of general fixes and only stable to PyPi * fix: small cleanup * fix: Small fixes and hopefully fixes the GUI tests * fix: Add proper library paths for FreeCAD GUI in CI - Create wrapper scripts instead of symlinks for AppImage binaries - Set LD_LIBRARY_PATH, QT_PLUGIN_PATH for GUI mode - Add diagnostic output to identify startup failures * fix: Use apprun for GUI tests in CI * fix: Improving Xvfb tests * fix: GUI tests worlk * chore: remove invalid --no-splash comments * fix: ARM64 architecture support and other fixes * fix: cleanup * test: just commands test suite * test: improve just command tests * fix: more general improvements * fix: more cleanup * fix: more updates * fix: small tweaks --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
77 lines
2.5 KiB
Python
77 lines
2.5 KiB
Python
"""Tests for testing module just commands.
|
|
|
|
These tests verify that test commands work correctly.
|
|
Note: We avoid running integration tests here to prevent recursion.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING, ClassVar
|
|
|
|
import pytest
|
|
|
|
from tests.just_commands.conftest import assert_command_executed
|
|
|
|
if TYPE_CHECKING:
|
|
from tests.just_commands.conftest import JustRunner
|
|
|
|
|
|
class TestTestingSyntax:
|
|
"""Syntax validation tests for testing commands."""
|
|
|
|
TESTING_COMMANDS: ClassVar[list[str]] = [
|
|
"testing::unit",
|
|
"testing::cov",
|
|
"testing::fast",
|
|
"testing::integration",
|
|
"testing::verbose",
|
|
"testing::all",
|
|
"testing::watch",
|
|
"testing::integration-freecad-auto",
|
|
"testing::kill-bridge",
|
|
]
|
|
|
|
@pytest.mark.just_syntax
|
|
@pytest.mark.parametrize("command", TESTING_COMMANDS)
|
|
def test_testing_command_syntax(self, just: JustRunner, command: str) -> None:
|
|
"""Testing command should have valid syntax."""
|
|
result = just.dry_run(command)
|
|
assert result.success, f"Syntax error in '{command}': {result.stderr}"
|
|
|
|
|
|
class TestTestingRuntime:
|
|
"""Runtime tests for testing commands.
|
|
|
|
Note: We use --collect-only or run minimal tests to avoid
|
|
long execution times and recursion issues.
|
|
"""
|
|
|
|
@pytest.mark.just_runtime
|
|
def test_kill_bridge_runs(self, just: JustRunner) -> None:
|
|
"""Kill-bridge command should run (even if nothing to kill)."""
|
|
result = just.run("testing::kill-bridge", timeout=30)
|
|
# Should succeed even if no processes to kill
|
|
assert result.success, f"Kill-bridge failed: {result.stderr}"
|
|
|
|
@pytest.mark.just_runtime
|
|
def test_unit_command_recognizes_pytest(self, just: JustRunner) -> None:
|
|
"""Unit test command should at least recognize pytest."""
|
|
# Run with --collect-only to just validate pytest setup
|
|
result = just.run(
|
|
"testing::unit",
|
|
timeout=60,
|
|
env={"PYTEST_ADDOPTS": "--collect-only -q"},
|
|
)
|
|
# Should at least find some tests or run without error
|
|
assert_command_executed(result, "testing::unit")
|
|
|
|
@pytest.mark.just_runtime
|
|
def test_fast_command_recognizes_markers(self, just: JustRunner) -> None:
|
|
"""Fast test command should recognize the 'not slow' marker."""
|
|
result = just.run(
|
|
"testing::fast",
|
|
timeout=60,
|
|
env={"PYTEST_ADDOPTS": "--collect-only -q"},
|
|
)
|
|
assert_command_executed(result, "testing::fast")
|