Files
freecad-robust-mcp-fc111/tests/just_commands/test_coderabbit.py
T
8c338f6da7 feat: MCP Bridge Workbench, just command cleanup, testing, etc. (#24)
* fix: lots of fixes and name refactoring

* feat: Add workbench preferences

* fix: MCP bridge status widget and just command fixes

* fix(tests): Use the correct mesa-glx package

* fix(ci): Add fontconfig to GUI test dependencies

FreeCAD GUI was failing to start with:
"Fontconfig error: Cannot load default config file: No such file"

Added fontconfig and fonts-dejavu-core packages to the GUI test job
dependencies to resolve the font configuration issue.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(addon): Extract path utilities into shared module

Create path_utils.py module that consolidates duplicated path-finding
logic from commands.py and InitGui.py:
- get_addon_path(): Find addon directory with caching and fallbacks
- get_icon_path(): Get full path to an icon file
- get_icons_dir(): Get path to icons directory
- get_workbench_icon(): Get path to workbench main icon

This removes ~100 lines of duplicated code while preserving the same
behavior including _addon_path_cache and all fallback methods.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(addon): Prevent stale plugin state on startup failure

The StartMCPBridgeCommand.Activated method could leave _mcp_plugin in
a partially initialized state if FreecadMCPPlugin.start() failed after
the plugin was instantiated.

Changes:
- Create plugin in a local variable first
- Only assign to _mcp_plugin after start() succeeds
- Explicitly clear _mcp_plugin and _running_config in exception
  handlers to ensure clean state for subsequent retry attempts

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: Lot of broad improvements

* fix(ci): Use blocking headless_server.py for GUI tests

The GUI test was using startup_bridge.py which is non-blocking
(designed for interactive use). For CI, even in GUI mode, we need
the blocking headless_server.py that calls run_forever() to keep
FreeCAD running. GUI features are still available since we use
the 'freecad' executable instead of 'freecadcmd'.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(addon): Rename headless_server.py to blocking_bridge.py

The old name was misleading because:
- It works with both GUI (freecad) and headless (freecadcmd) modes
- The key characteristic is that it BLOCKS with run_forever()

New naming convention clarifies the difference:
- blocking_bridge.py: Starts bridge and blocks (for CI, servers)
- startup_bridge.py: Starts bridge and returns (for interactive GUI)

Updated all references across:
- GitHub workflow (macro-test.yaml)
- Just commands (freecad.just)
- Unit tests (test_addon_structure.py)
- Documentation (5 files)
- CLAUDE.md

Also improved the script to detect GUI mode dynamically using
FreeCAD.GuiUp and display the appropriate status message.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(just): Remove erroneous rm of startup_bridge.py on error

The startup script is now a permanent source file in the repository,
not a generated temporary file. The rm -f would have deleted source
code if FreeCAD wasn't found.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: General improvements

* fix: Lots of general fixes and only stable to PyPi

* fix: small cleanup

* fix: Small fixes and hopefully fixes the GUI tests

* fix: Add proper library paths for FreeCAD GUI in CI

- Create wrapper scripts instead of symlinks for AppImage binaries
- Set LD_LIBRARY_PATH, QT_PLUGIN_PATH for GUI mode
- Add diagnostic output to identify startup failures

* fix: Use apprun for GUI tests in CI

* fix: Improving Xvfb tests

* fix: GUI tests worlk

* chore: remove invalid --no-splash comments

* fix: ARM64 architecture support and other fixes

* fix: cleanup

* test: just commands test suite

* test: improve just command tests

* fix: more general improvements

* fix: more cleanup

* fix: more updates

* fix: small tweaks

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-10 15:26:33 -08:00

77 lines
2.5 KiB
Python

"""Tests for coderabbit module just commands.
These tests verify that CodeRabbit CLI commands work correctly.
Note: Most commands require CodeRabbit CLI to be installed and authenticated.
"""
from __future__ import annotations
import shutil
from typing import TYPE_CHECKING, ClassVar
import pytest
if TYPE_CHECKING:
from tests.just_commands.conftest import JustRunner
def coderabbit_available() -> bool:
"""Check if CodeRabbit CLI is available."""
return shutil.which("coderabbit") is not None
class TestCoderabbitSyntax:
"""Syntax validation tests for CodeRabbit commands."""
CODERABBIT_COMMANDS: ClassVar[list[str]] = [
"coderabbit::install",
"coderabbit::check-installed",
"coderabbit::login",
"coderabbit::logout",
"coderabbit::auth-status",
"coderabbit::review",
"coderabbit::review-fix",
"coderabbit::review-all",
"coderabbit::review-last",
"coderabbit::review-since",
"coderabbit::review-branch",
"coderabbit::prompt-only",
"coderabbit::review-json",
"coderabbit::help",
"coderabbit::version",
]
@pytest.mark.just_syntax
@pytest.mark.parametrize("command", CODERABBIT_COMMANDS)
def test_coderabbit_command_syntax(self, just: JustRunner, command: str) -> None:
"""CodeRabbit command should have valid syntax."""
# Commands with required arguments
if command == "coderabbit::review-since":
result = just.dry_run(command, "HEAD~5")
else:
result = just.dry_run(command)
assert result.success, f"Syntax error in '{command}': {result.stderr}"
class TestCoderabbitRuntime:
"""Runtime tests for CodeRabbit commands."""
@pytest.mark.just_runtime
def test_check_installed_reports_status(self, just: JustRunner) -> None:
"""check-installed should report installation status."""
result = just.run("coderabbit::check-installed", timeout=10)
if coderabbit_available():
assert result.success
else:
# Should fail with helpful message
assert not result.success
assert "not installed" in result.output.lower()
@pytest.mark.just_runtime
def test_version_runs(self, just: JustRunner) -> None:
"""version command should run if CodeRabbit is installed."""
if not coderabbit_available():
pytest.skip("CodeRabbit CLI not installed")
result = just.run("coderabbit::version", timeout=10)
assert result.success, f"Version failed: {result.stderr}"