8c338f6da7
* fix: lots of fixes and name refactoring * feat: Add workbench preferences * fix: MCP bridge status widget and just command fixes * fix(tests): Use the correct mesa-glx package * fix(ci): Add fontconfig to GUI test dependencies FreeCAD GUI was failing to start with: "Fontconfig error: Cannot load default config file: No such file" Added fontconfig and fonts-dejavu-core packages to the GUI test job dependencies to resolve the font configuration issue. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(addon): Extract path utilities into shared module Create path_utils.py module that consolidates duplicated path-finding logic from commands.py and InitGui.py: - get_addon_path(): Find addon directory with caching and fallbacks - get_icon_path(): Get full path to an icon file - get_icons_dir(): Get path to icons directory - get_workbench_icon(): Get path to workbench main icon This removes ~100 lines of duplicated code while preserving the same behavior including _addon_path_cache and all fallback methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(addon): Prevent stale plugin state on startup failure The StartMCPBridgeCommand.Activated method could leave _mcp_plugin in a partially initialized state if FreecadMCPPlugin.start() failed after the plugin was instantiated. Changes: - Create plugin in a local variable first - Only assign to _mcp_plugin after start() succeeds - Explicitly clear _mcp_plugin and _running_config in exception handlers to ensure clean state for subsequent retry attempts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Lot of broad improvements * fix(ci): Use blocking headless_server.py for GUI tests The GUI test was using startup_bridge.py which is non-blocking (designed for interactive use). For CI, even in GUI mode, we need the blocking headless_server.py that calls run_forever() to keep FreeCAD running. GUI features are still available since we use the 'freecad' executable instead of 'freecadcmd'. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(addon): Rename headless_server.py to blocking_bridge.py The old name was misleading because: - It works with both GUI (freecad) and headless (freecadcmd) modes - The key characteristic is that it BLOCKS with run_forever() New naming convention clarifies the difference: - blocking_bridge.py: Starts bridge and blocks (for CI, servers) - startup_bridge.py: Starts bridge and returns (for interactive GUI) Updated all references across: - GitHub workflow (macro-test.yaml) - Just commands (freecad.just) - Unit tests (test_addon_structure.py) - Documentation (5 files) - CLAUDE.md Also improved the script to detect GUI mode dynamically using FreeCAD.GuiUp and display the appropriate status message. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(just): Remove erroneous rm of startup_bridge.py on error The startup script is now a permanent source file in the repository, not a generated temporary file. The rm -f would have deleted source code if FreeCAD wasn't found. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: General improvements * fix: Lots of general fixes and only stable to PyPi * fix: small cleanup * fix: Small fixes and hopefully fixes the GUI tests * fix: Add proper library paths for FreeCAD GUI in CI - Create wrapper scripts instead of symlinks for AppImage binaries - Set LD_LIBRARY_PATH, QT_PLUGIN_PATH for GUI mode - Add diagnostic output to identify startup failures * fix: Use apprun for GUI tests in CI * fix: Improving Xvfb tests * fix: GUI tests worlk * chore: remove invalid --no-splash comments * fix: ARM64 architecture support and other fixes * fix: cleanup * test: just commands test suite * test: improve just command tests * fix: more general improvements * fix: more cleanup * fix: more updates * fix: small tweaks --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
80 lines
2.8 KiB
Python
80 lines
2.8 KiB
Python
"""Tests for install module just commands.
|
|
|
|
These tests verify that installation commands work correctly.
|
|
Note: Some tests may modify local installations.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING, ClassVar
|
|
|
|
import pytest
|
|
|
|
if TYPE_CHECKING:
|
|
from tests.just_commands.conftest import JustRunner
|
|
|
|
|
|
class TestInstallSyntax:
|
|
"""Syntax validation tests for install commands."""
|
|
|
|
INSTALL_COMMANDS: ClassVar[list[str]] = [
|
|
"install::mcp-server",
|
|
"install::mcp-server-clean",
|
|
"install::uninstall-mcp-server",
|
|
"install::mcp-bridge-workbench",
|
|
"install::uninstall-mcp-bridge-workbench",
|
|
"install::macro-cut",
|
|
"install::uninstall-macro-cut",
|
|
"install::macro-export",
|
|
"install::uninstall-macro-export",
|
|
"install::macro-all",
|
|
"install::uninstall-macro-all",
|
|
"install::status",
|
|
]
|
|
|
|
@pytest.mark.just_syntax
|
|
@pytest.mark.parametrize("command", INSTALL_COMMANDS)
|
|
def test_install_command_syntax(self, just: JustRunner, command: str) -> None:
|
|
"""Install command should have valid syntax."""
|
|
result = just.dry_run(command)
|
|
assert result.success, f"Syntax error in '{command}': {result.stderr}"
|
|
|
|
|
|
class TestInstallRuntime:
|
|
"""Runtime tests for install commands."""
|
|
|
|
@pytest.mark.just_runtime
|
|
def test_status_runs(self, just: JustRunner) -> None:
|
|
"""Status command should run and show installation status."""
|
|
result = just.run("install::status", timeout=60)
|
|
assert result.success, f"Status failed: {result.stderr}"
|
|
# Should contain some expected output
|
|
assert "Installation Status" in result.stdout
|
|
|
|
@pytest.mark.just_runtime
|
|
def test_freecad_dirs_helper_runs(self, just: JustRunner) -> None:
|
|
"""Private _freecad-dirs helper should work."""
|
|
result = just.run("install::_freecad-dirs", timeout=10)
|
|
assert result.success, f"_freecad-dirs failed: {result.stderr}"
|
|
# Should output shell code to set directories
|
|
assert "MOD_DIR" in result.stdout
|
|
assert "MACRO_DIR" in result.stdout
|
|
|
|
@pytest.mark.just_runtime
|
|
@pytest.mark.slow
|
|
def test_mcp_server_install_uninstall(self, just: JustRunner) -> None:
|
|
"""MCP server install and uninstall should work."""
|
|
# Install
|
|
result = just.run("install::mcp-server", timeout=300)
|
|
assert result.success, f"MCP server install failed: {result.stderr}"
|
|
|
|
# Verify installation
|
|
status_result = just.run("install::status", timeout=60)
|
|
assert "Robust MCP Server" in status_result.stdout
|
|
|
|
# Uninstall
|
|
uninstall_result = just.run("install::uninstall-mcp-server", timeout=60)
|
|
assert uninstall_result.success, (
|
|
f"MCP server uninstall failed: {uninstall_result.stderr}"
|
|
)
|