forkless/strix
1
0
Fork 0
mirror of https://github.com/usestrix/strix.git synced 2026-08-16 09:26:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(runtime): close the docker client on session cleanup (#787)

Browse Source
This commit is contained in:
Ahmed Allam
2026-07-16 11:06:18 -07:00
committed by GitHub
parent e2eb39a02e
commit af65796ec0
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
strix/runtime/session_manager.py
+9 -1
View File
@@ -167,11 +167,19 @@ async def cleanup(scan_id: str) -> None:
except Exception: # noqa: BLE001 except Exception: # noqa: BLE001
logger.debug("cleanup(%s): caido_client.aclose() raised", scan_id, exc_info=True) logger.debug("cleanup(%s): caido_client.aclose() raised", scan_id, exc_info=True)
client = bundle["client"]
try: try:
await bundle["client"].delete(bundle["session"]) await client.delete(bundle["session"])
logger.info("Cleaned up sandbox session for scan %s", scan_id) logger.info("Cleaned up sandbox session for scan %s", scan_id)
except Exception: except Exception:
logger.exception( logger.exception(
"cleanup(%s): client.delete raised; container may need manual reaping", "cleanup(%s): client.delete raised; container may need manual reaping",
scan_id, scan_id,
) )
docker_client = getattr(client, "docker_client", None)
if docker_client is not None:
try:
docker_client.close()
except Exception: # noqa: BLE001
logger.debug("cleanup(%s): docker_client.close() raised", scan_id, exc_info=True)