feat(safety): workspace-file reads, approval UX, and integration hardening

Engine + integration:
- Reviewer inspection now surfaces the real frozen source of an already-frozen
  workspace script/dependency instead of an empty string, so workspace-resident
  scripts resolve without a needless human defer.
- Guard effectful static tools via an explicit, documented set plus the SDK's
  per-tool needs_approval signal; give the exec/stdin wrappers the same
  idempotency guard as their sibling wrappers.
- Centralize DEFAULT_SAFETY_MODE and share one resume safety-mode rule between the
  CLI and runner so the two cannot drift; type InspectionContext.runner, reuse
  RUNTIME_STATE_DIR_NAME, and drop a dead workdir parameter and a write-only field.

TUI approval experience:
- Approve All drops the run into dangerous mode: it approves the pending call and
  turns review off for the rest of the run, with a standing "review off" status flag.
- The status row shows the owning agent as paused while it waits on a decision.
- Redesigned prompt: a risk + tool header, a collapsible command/reason preview
  that expands (e) and scrolls, and no internal digest, agent, or request ids.

Full Python (1138) and Go suites, ruff, and mypy strix/ pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
oyasumi
2026-08-12 05:33:47 +00:00
co-authored by Claude Opus 4.8
parent 41b7b4f392
commit ccbd8c7b58
37 changed files with 4070 additions and 419 deletions
+31
View File
@@ -123,6 +123,37 @@ def test_function_tools_are_result_bounded() -> None:
assert getattr(by_name["think"], "_strix_bounded", False) is True
def test_only_effectful_static_tools_are_safety_guarded() -> None:
# Pins the safety classification of the base tool set: the one effectful
# static function tool is guarded for pre-execution review, while internal
# bookkeeping and read-only tools run unreviewed. Guarding a read-only tool
# would serialize it on the workspace lock and churn other agents' review
# epochs, so a new effectful tool must be added to _MUTATING_STATIC_TOOLS.
agent = factory.build_strix_agent(is_root=True)
by_name = {t.name: t for t in agent.tools}
assert getattr(by_name["repeat_request"], "_strix_safety_guarded", False) is True
for name in ("think", "web_search", "list_requests", "create_note", "view_agent_graph"):
assert getattr(by_name[name], "_strix_safety_guarded", False) is False, name
def test_safety_guard_honors_the_sdk_needs_approval_signal() -> None:
async def invoke(_ctx: Any, _raw: str) -> str:
return "ok"
future_tool = FunctionTool(
name="some_future_effectful_tool",
description="test tool",
params_json_schema={"type": "object", "properties": {}},
on_invoke_tool=invoke,
needs_approval=True,
)
guarded = factory._with_safety_guard(future_tool)
assert getattr(guarded, "_strix_safety_guarded", False) is True
def _capturing_stdin_tool(captured: dict[str, str]) -> FunctionTool:
async def invoke(_ctx: Any, raw_input: str) -> str:
captured["raw_input"] = raw_input