mirror of
https://github.com/usestrix/strix.git
synced 2026-08-19 10:05:12 +02:00
- Strip PLAYBOOK / AUDIT / Phase-N / C-numbered references from module docstrings across 16 files; rename ``_PHASE1_PARALLEL_DEFAULT`` → ``_PARALLEL_TOOL_CALLS_DEFAULT``. - Delete unused exception classes: ``SandboxInitializationError``, ``ImplementedInClientSideOnlyError``. - Delete the no-op ``on_handoff`` hook (we don't use SDK handoffs). - Delete the unreachable backward-compat tab-delimited fallback in ``_parse_git_diff_output``. - Delete orphaned ``strix/tools/load_skill/`` (dir contained only a pycache) and stale pycache files. - Rewrite ``strix/skills/__init__.py``: 168 → 56 LoC. Drop seven helper functions (``get_available_skills``, ``get_all_skill_names``, ``validate_skill_names``, ``parse_skill_list``, ``validate_requested_skills``, ``generate_skills_description``, ``_get_all_categories``) — none had external callers; only ``load_skills`` is used. - Drop the stale ``strix/agents/sdk_factory.py`` per-file ruff ignore (file no longer exists).
170 lines
5.5 KiB
Python
170 lines
5.5 KiB
Python
"""``StrixTracingProcessor`` — SDK trace processor that writes ``events.jsonl``.
|
|
|
|
Hooks into the SDK's tracing pipeline and writes events to
|
|
``strix_runs/<run-name>/events.jsonl``. PII scrubbing runs through
|
|
:class:`TelemetrySanitizer`.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import logging
|
|
import threading
|
|
from pathlib import Path
|
|
from typing import TYPE_CHECKING, Any
|
|
|
|
from agents.tracing.processor_interface import TracingProcessor
|
|
|
|
|
|
if TYPE_CHECKING:
|
|
from agents.tracing.spans import Span
|
|
from agents.tracing.traces import Trace
|
|
|
|
from strix.telemetry.utils import TelemetrySanitizer
|
|
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
# Module-level lock registry — one per JSONL file so two processors writing
|
|
# different run-dirs don't serialize unnecessarily, but two processors
|
|
# writing the *same* run-dir do.
|
|
_FILE_LOCKS: dict[Path, threading.Lock] = {}
|
|
_GUARD = threading.Lock()
|
|
|
|
|
|
def _lock_for(path: Path) -> threading.Lock:
|
|
with _GUARD:
|
|
return _FILE_LOCKS.setdefault(path, threading.Lock())
|
|
|
|
|
|
class StrixTracingProcessor(TracingProcessor):
|
|
"""Append trace + span events as JSONL into ``run_dir/events.jsonl``.
|
|
|
|
Every hook is synchronous — required by the ``TracingProcessor``
|
|
ABC. Each write is protected by a per-path ``threading.Lock`` so
|
|
concurrent spans can't interleave bytes mid-line. ``OSError`` is
|
|
swallowed so a full disk or permission error doesn't tear the run
|
|
down. PII scrubbing runs on every event before it hits the file.
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
run_dir: Path,
|
|
sanitizer: TelemetrySanitizer | None = None,
|
|
) -> None:
|
|
run_dir = Path(run_dir)
|
|
run_dir.mkdir(parents=True, exist_ok=True)
|
|
self.run_dir: Path = run_dir
|
|
self.events_path: Path = run_dir / "events.jsonl"
|
|
if sanitizer is None:
|
|
from strix.telemetry.utils import TelemetrySanitizer
|
|
|
|
sanitizer = TelemetrySanitizer()
|
|
self.sanitizer: TelemetrySanitizer = sanitizer
|
|
|
|
# --- Internal helpers -------------------------------------------------
|
|
|
|
def _emit(self, event: dict[str, Any]) -> None:
|
|
"""Sanitize ``event`` and append it as one JSONL line.
|
|
|
|
Failures are swallowed — we'd rather lose a trace event than
|
|
fail the run.
|
|
"""
|
|
try:
|
|
clean = self.sanitizer.sanitize(event)
|
|
except Exception:
|
|
logger.exception("Trace event sanitization failed; dropping event")
|
|
return
|
|
try:
|
|
with (
|
|
_lock_for(self.events_path),
|
|
self.events_path.open(
|
|
"a",
|
|
encoding="utf-8",
|
|
) as f,
|
|
):
|
|
f.write(json.dumps(clean, ensure_ascii=True) + "\n")
|
|
except OSError:
|
|
logger.exception("Failed to append trace event to %s", self.events_path)
|
|
|
|
@staticmethod
|
|
def _span_kind(span: Span[Any]) -> str:
|
|
"""Map ``SomethingSpanData`` → ``"something"`` for the event_type."""
|
|
name = type(span.span_data).__name__
|
|
if name.endswith("SpanData"):
|
|
name = name[: -len("SpanData")]
|
|
return name.lower() or "span"
|
|
|
|
@staticmethod
|
|
def _trace_metadata(trace: Trace) -> dict[str, Any]:
|
|
meta: dict[str, Any] = {"name": getattr(trace, "name", None)}
|
|
# ``Trace.export()`` includes metadata + group_id when set.
|
|
try:
|
|
exported = trace.export()
|
|
if isinstance(exported, dict):
|
|
for key in ("metadata", "group_id", "workflow_name"):
|
|
if key in exported and exported[key] is not None:
|
|
meta[key] = exported[key]
|
|
except Exception:
|
|
logger.debug("trace.export failed", exc_info=True)
|
|
return meta
|
|
|
|
# --- TracingProcessor ABC --------------------------------------------
|
|
|
|
def on_trace_start(self, trace: Trace) -> None:
|
|
self._emit(
|
|
{
|
|
"event_type": "run.started",
|
|
"trace_id": trace.trace_id,
|
|
"metadata": self._trace_metadata(trace),
|
|
}
|
|
)
|
|
|
|
def on_trace_end(self, trace: Trace) -> None:
|
|
self._emit(
|
|
{
|
|
"event_type": "run.completed",
|
|
"trace_id": trace.trace_id,
|
|
}
|
|
)
|
|
|
|
def on_span_start(self, span: Span[Any]) -> None:
|
|
kind = self._span_kind(span)
|
|
self._emit(
|
|
{
|
|
"event_type": f"{kind}.started",
|
|
"span_id": span.span_id,
|
|
"trace_id": span.trace_id,
|
|
"data": self._safe_export(span),
|
|
}
|
|
)
|
|
|
|
def on_span_end(self, span: Span[Any]) -> None:
|
|
kind = self._span_kind(span)
|
|
self._emit(
|
|
{
|
|
"event_type": f"{kind}.completed",
|
|
"span_id": span.span_id,
|
|
"trace_id": span.trace_id,
|
|
"data": self._safe_export(span),
|
|
}
|
|
)
|
|
|
|
def force_flush(self) -> None:
|
|
"""All writes are synchronous; nothing to flush."""
|
|
|
|
def shutdown(self) -> None:
|
|
"""No-op; nothing to release."""
|
|
|
|
# --- helpers ----------------------------------------------------------
|
|
|
|
@staticmethod
|
|
def _safe_export(span: Span[Any]) -> dict[str, Any] | None:
|
|
try:
|
|
data = span.span_data.export()
|
|
return data if isinstance(data, dict) else None
|
|
except Exception:
|
|
logger.debug("span_data.export failed for %s", span.span_id, exc_info=True)
|
|
return None
|