0xallam e6b5b1ede5 fix(legacy): silence ruff + mypy errors surfaced by litellm 1.83 bump ...

Three modules touched in Phase 0 surfaced latent issues:

  - llm/llm.py:_extract_thinking — choices[0].message can be None or a
    TextChoices variant without thinking_blocks under the new stubs.
    Narrow via getattr+Any; restructure return through the else block
    so try/except/else is ruff-clean (TRY300).
  - llm/__init__.py:litellm._logging._disable_debugging is now untyped;
    suppress with explicit type:ignore.
  - tools/notes/notes_actions.py:append_note_content — drop dead-code
    isinstance check (delta is typed str at the boundary), and cast the
    update_note return through a typed local in the try/else flow.

Plus per-file PLC0415 ignore for two modules whose lazy imports exist
to break the circular dependency on strix.telemetry. Pre-commit
auto-formatter strips inline #noqa comments, so the suppress lives in
pyproject.toml until the dep graph is refactored.

No behavior change. 165/165 tests pass.

2026-04-24 23:50:20 -07:00

..

__init__.py

feat: Better source-aware testing (#391)

2026-03-31 11:53:49 -07:00

notes_actions_schema.xml

feat: Better source-aware testing (#391)

2026-03-31 11:53:49 -07:00

notes_actions.py

fix(legacy): silence ruff + mypy errors surfaced by litellm 1.83 bump

2026-04-24 23:50:20 -07:00